Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that generated method sets satisfy crossplane-runtime interfaces #3

Closed
negz opened this issue Oct 4, 2019 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@negz
Copy link
Member

negz commented Oct 4, 2019

What problem are you facing?

angryjet intends to generate method sets for types such that they satisfy various crossplane-runtime interfaces. Per https://github.com/crossplaneio/crossplane/pull/856/files#r330327715 previously we would add interface satisfaction tests, e.g.:

It's less likely that generated code will accidentally not satisfy these interfaces, but still worth testing. It's possible for example that angryjet is targeting a newer or older version of crossplane-runtime than the project using generation is targeting.

How could Crossplane help solve your problem?

Teach angryjet to generate interface satisfaction tests, e.g.:

var _ resource.Claim = &RedisCluster{}
@negz negz added the enhancement New feature or request label Oct 4, 2019
@negz
Copy link
Member Author

negz commented Oct 4, 2019

Dupe of #2.

@negz negz closed this as completed Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant