Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Some functions in zksync web3 sdk are not needed #34

Open
thomas-nguy opened this issue Jul 28, 2023 · 3 comments · May be fixed by cronos-labs/era-contracts#6
Open

[Core] Some functions in zksync web3 sdk are not needed #34

thomas-nguy opened this issue Jul 28, 2023 · 3 comments · May be fixed by cronos-labs/era-contracts#6
Assignees
@JayT106

Comments

@thomas-nguy
Copy link
Member

thomas-nguy commented Jul 28, 2023 •
edited
Loading

Operations related to WethBridge needs to be removed from the zksync-web3-sdk

We will not deploy WethBridge in CronosV2 because the CronosV2 will be using CRO as native token, not ETH

We can deal with WETH the same way we are dealing with any ERC20 (Using the ERC20Bridge)

Thus all operations to WethBridge can be removed from the sdk
@JayT106 JayT106 self-assigned this Jul 31, 2023
@JayT106 JayT106 mentioned this issue Jul 31, 2023
Closed
@JayT106
Copy link
Contributor

JayT106 commented Jul 31, 2023

the PR removed the weth bridge in the sdk side which fit this ticket's requirement.

But in the contract deploying scripts still deploy the bridges, so the zk init will still deploy the bridges just the SDK cannot access it. Do we want to remove it too?

@thomas-nguy
Copy link
Member Author

yes I think its better to remove

@JayT106 JayT106 linked a pull request Aug 1, 2023 that will close this issue
Open
@JayT106
Copy link
Contributor

JayT106 commented Aug 1, 2023

yes I think its better to remove

removed the weth bridge deploy in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JayT106 JayT106

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JayT106 @thomas-nguy