Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info to Contribute section #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lenicatko
Copy link

@lenicatko lenicatko commented Jan 3, 2023

Added purpose of different comms channels, link to contributing.md, added link to additional resources from Awesome CRI-O.

none

@openshift-ci openshift-ci bot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Jan 3, 2023
@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lenicatko
Once this PR has been reviewed and has the lgtm label, please assign haircommander for approval by writing /assign @haircommander in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jan 3, 2023
index.md Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 3, 2023
index.md Outdated
@@ -38,7 +38,7 @@ Join #crio on [Kubernetes Slack](https://slack.k8s.io/)
To install on the following operating systems, set the environment variable `$OS` as the appropriate field in the following table:

| Operating system | $OS |
| ---------------- | ----------------- |
|------------------|-------------------|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this change caused the table to highlight every other row. That's fine, but the backticks also do that too, and you end up with a double highlight, that IMO looks a bit wonky. I'd vote to use one of these changes, the backticks of the OS names, or this change, but not both.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I opened it with ./script/server, the formatting was the same as before after this change, so I was not aware of this issue with highlighting every other row. I can return it back, as I agree, double highlighting would look strange, I am just confused why I can't see this when opening it locally.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2023
@lenicatko
Copy link
Author

I didn't notice, I will rebase.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2023
@openshift-ci openshift-ci bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 10, 2023
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jan 10, 2023
@lenicatko lenicatko force-pushed the contribute-community-update branch 2 times, most recently from 67b944b to 340f3d9 Compare January 10, 2023 17:53
@lenicatko lenicatko changed the title Adding more info to Contribute section Add more info to Contribute section Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants