Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some text for CC0 image attribution #134

Open
siccovansas opened this issue Oct 28, 2020 · 6 comments
Open

Change some text for CC0 image attribution #134

siccovansas opened this issue Oct 28, 2020 · 6 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧹 status: ticket work required Needs more details before it can be worked on

Comments

@siccovansas
Copy link

Description

When I go to my WordPress Media page and add a CC0 license to an image the generated license text for that image is:

Except where otherwise noted, the content on this site is licensed under a CC0 1.0 Universal License.

Shouldn't it be something like:

Except where otherwise noted, this media is licensed under a CC0 1.0 Universal License.

And maybe the "Except where otherwise noted, " should be removed as well when licensing media?

Reproduction

  1. Add a CC0 license to media
  2. See text

Expectation

Expect text specifying that the license only holds for that image instead of the whole site.

Environment

  • Browser: Firefox 81.0.2
  • Version: v2020.09.1
@siccovansas siccovansas added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Oct 28, 2020
@ankitmishra88
Copy link

Hello, I have a good hand on wordpress plugin development and customization. But almost no with open source, I want to fix this particular issue. Can u please explain a bit more, how I can reproduce this behaviour, I tried to add license in media library, also I added that to a post. But couldn't find attribution text. Please let me know, how I can check the issue?

@nishantwrp
Copy link
Contributor

Hi @siccovansas, can you please elaborate on what text are you exactly talking about? I added a license to a image and I could see no text generated.

Unnamed

@siccovansas
Copy link
Author

Hi @nishantwrp, the text I get is generated by the license_html_rdfa function which I call in a script to add the license to media.

@nishantwrp
Copy link
Contributor

Hi, I still can't get how this function is used to generate licenses for media. Can you please maybe provide some steps/screenshots to reproduce this error?

@siccovansas
Copy link
Author

@nishantwrp you can find the code in which we call the license_html_rdfa function here: https://github.com/openstate/open-state-theme-2019/blob/94ff57a84377c34376f39aa793e57b9c0e0c4d08/app/filters.php#L155-L270

@nishantwrp
Copy link
Contributor

nishantwrp commented Mar 4, 2021

Hi @siccovansas, actually that function is used in this plugin to generate_rdfa on the complete site i.e. by footer or widget. I don't think there is such function for image attributes (@hugosolar please confirm). However, I think you can do something like

<p>
This content is licensed by{' '}
<a href="https://creativecommons.org/publicdomain/zero/1.0/">
Creative Commons CC0 Universal Public Domain Dedication license.
</a>
</p>

@possumbilities possumbilities added 🧹 status: ticket work required Needs more details before it can be worked on and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧹 status: ticket work required Needs more details before it can be worked on
Projects
Status: Backlog
Development

No branches or pull requests

4 participants