Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] logos/social icons flash purple briefly on click #10

Open
1 task done
possumbilities opened this issue Oct 18, 2023 · 1 comment · May be fixed by #83
Open
1 task done

[Bug] logos/social icons flash purple briefly on click #10

possumbilities opened this issue Oct 18, 2023 · 1 comment · May be fixed by #83
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software 🟩 priority: low Low priority and doesn't need to be rushed 🏷 status: label work required Needs proper labelling before it can be worked on 🏁 status: ready for work Ready for work

Comments

@possumbilities
Copy link
Contributor

Description

when clicked the logos and social icons flash to a purple color briefly on click. This is due to the fact that the way in which the logo and social icons was implemented sets the svg a mask of the element, rather than to a mask of a child pseudo element of :before or :after. This disallows any outline or border indicators on that element for a :focus state. To correct for this in a temporary fashion, color was used to denote an item "in focus".

As a side effect when an item is clicked it is briefly "in focus", which makes it turn purple.

However, this behavior needs to change, so that proper outline behavior will occur.

Reproduction

  1. Click the logo
  2. See it briefly turn purple

Expectation

The items in question need to have standard default browser outline focus indicators, and the method of svg replacement needs to be moved to a child pseudo element to allow for this.

Resolution

  • I would be interested in resolving this bug.
@possumbilities possumbilities self-assigned this Oct 18, 2023
@possumbilities possumbilities transferred this issue from creativecommons/index-prototype Apr 24, 2024
@cc-open-source-bot cc-open-source-bot added the 🏷 status: label work required Needs proper labelling before it can be worked on label Apr 25, 2024
@possumbilities possumbilities added 🏁 status: ready for work Ready for work 💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software 🟩 priority: low Low priority and doesn't need to be rushed and removed 🏷 status: label work required Needs proper labelling before it can be worked on labels Sep 18, 2024
@cc-open-source-bot cc-open-source-bot added the 🏷 status: label work required Needs proper labelling before it can be worked on label Sep 19, 2024
@Vanessa082
Copy link
Contributor

I am interested in working on this

@blossomese blossomese linked a pull request Oct 4, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software 🟩 priority: low Low priority and doesn't need to be rushed 🏷 status: label work required Needs proper labelling before it can be worked on 🏁 status: ready for work Ready for work
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants