Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Images of empowerment' as an external source #156

Open
1 task done
JennySimen opened this issue Oct 28, 2022 · 9 comments
Open
1 task done

Add 'Images of empowerment' as an external source #156

JennySimen opened this issue Oct 28, 2022 · 9 comments
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work

Comments

@JennySimen
Copy link
Contributor

Problem

The goal is to add a good number of external sources to give users a variety of results from different sources.

Description

Images of empowerment is a free site where we can get images on women’s lives and work. it is also licensed under Creative Commons Attribution-NonCommercial 4.0 International. Gotten from the additional sources list of Openverse available in the file get-additional-sources.ts mentioned in #48

Adding Images of empowerment as an external source to CC search will be a good addition and will benefit our users by giving them more options.

Alternatives

Additional context

Implementation

  • I would be interested in implementing this feature.
@JennySimen JennySimen added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Oct 28, 2022
@JennySimen JennySimen changed the title Add 'Images on empowerment' as an external source Add 'Images of empowerment' as an external source Oct 28, 2022
@JennySimen
Copy link
Contributor Author

@possumbilities please triage this issue

@henryripcord
Copy link

Something like this ??

Screenshot 2022-10-29 at 03 17 12

@henryripcord
Copy link

If so, then I'd love to work on it

@Marvisjaja

This comment was marked as off-topic.

@Marvisjaja

This comment was marked as off-topic.

@possumbilities
Copy link
Contributor

@JennySimen Did you go through and verify that the engine meets this criteria? https://github.com/creativecommons/search/blob/main/guides/search_engines_inclusion_criteria.md

@possumbilities possumbilities added 🧹 status: ticket work required Needs more details before it can be worked on and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 31, 2022
@JennySimen
Copy link
Contributor Author

@possumbilities I have read through the criteria listed on
https://github.com/creativecommons/search/blob/main/guides/search_engines_inclusion_criteria.md and I affirm that the engine is inline with the criteria on the list.

@possumbilities
Copy link
Contributor

In reference to #160 to fully resolve this Issue the appropriate aria-label will need to be added to the engine button.

@possumbilities
Copy link
Contributor

The current Search Portal interface has an option for searching "use for commercial purposes", and since that's the case any engine we add with the current UX has to have some option to filter for that. However, this external source says the follow:

Use these images in your work. They’re free for nonprofit use, thanks to Creative Commons licensing (CC-BY-NC-4.0).

Therefore, I'm not sure, if at this time we can do this. So I'm moving this to blocked until such time as the interface can allow this level of nuance.

@possumbilities possumbilities added 🚧 status: blocked Blocked & therefore, not ready for work and removed 🧹 status: ticket work required Needs more details before it can be worked on labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants