Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align header with the Vocabulary design system #827

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Align header with the Vocabulary design system #827

wants to merge 7 commits into from

Conversation

Dev-JoyA
Copy link
Contributor

@Dev-JoyA Dev-JoyA commented Oct 8, 2024 •
edited by TimidRobot
Loading

Fixes

Description

This pull request implements the necessary adjustments to the header design to align with the current Vocabulary design system, including the addition of the 'Explore CC' dropdown and the 'Donate' button.

Technical details

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Dev-JoyA Dev-JoyA requested review from a team as code owners October 8, 2024 15:14
@Dev-JoyA Dev-JoyA requested review from TimidRobot, possumbilities and akmadian and removed request for a team October 8, 2024 15:14
TimidRobot

This comment was marked as outdated.

Sign in to view

@Dev-JoyA

This comment was marked as outdated.

Sign in to view
@SisiVero
Copy link

hi @Dev-JoyA , you can check and make updates or manually resolve the conflicts

@Dev-JoyA
Copy link
Contributor Author

@TimidRobot Conflicts resolved
@SisiVero Thanks for calling my attention to this

TimidRobot
TimidRobot requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR completely breaks the site:
Screenshot 2024-10-21 at 09-03-30 Welcome — Creative Commons Open Source

Please test changes before requesting review.

content/blog/entries/the-specifics-revamping-CCOS/contents.lr Show resolved Hide resolved
themes/vocabulary_theme/templates/page.html Outdated Show resolved Hide resolved
@Dev-JoyA
Copy link
Contributor Author

@TimidRobot This is the page after fixing the error and testing
Screenshot 2024-10-22 at 10 43 15

@Dev-JoyA Dev-JoyA force-pushed the feature/vocabulary-design-system-header branch from 38fe6b2 to 1f5d27c Compare October 22, 2024 10:15
@TimidRobot TimidRobot self-assigned this Oct 24, 2024
TimidRobot
TimidRobot requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds the current header on top of the old header. It needs to completely replace the old header:

Screenshot 2024-10-24 at 07-27-46 Welcome — Creative Commons Open Source

NOTE: this site uses a templating system that requires the reference implementation to be adapted.

assets/static/vocabulary/css/vocabulary.css Outdated Show resolved Hide resolved
assets/static/vocabulary/css/vocabulary.css Outdated Show resolved Hide resolved
content/blog/entries/the-specifics-revamping-CCOS/contents.lr Outdated Show resolved Hide resolved
themes/vocabulary_theme/templates/layout.html Outdated Show resolved Hide resolved
themes/vocabulary_theme/templates/layout.html Outdated Show resolved Hide resolved
themes/vocabulary_theme/templates/layout.html Outdated Show resolved Hide resolved
This was referenced Oct 24, 2024
Open
Open
@Dev-JoyA
Copy link
Contributor Author

Hello @TimidRobot I hope I get a thumps up from you this time around, the old header as been replaced with the new one
Screenshot 2024-10-24 at 16 09 31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@possumbilities possumbilities Awaiting requested review from possumbilities possumbilities is a code owner automatically assigned from creativecommons/technology

@akmadian akmadian Awaiting requested review from akmadian akmadian is a code owner automatically assigned from creativecommons/ct-cc-open-source-core-committers

@TimidRobot TimidRobot Awaiting requested review from TimidRobot

Assignees

@TimidRobot TimidRobot

Labels
None yet
Projects
Applications
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] The header does not align with the current Vocabulary design system
3 participants
@Dev-JoyA @SisiVero @TimidRobot