Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update reactivity of menu on scroll #537

Closed
wants to merge 19 commits into from
Closed

Conversation

Dhruvi16
Copy link
Member

@Dhruvi16 Dhruvi16 commented Oct 6, 2020

Fixes

Fixes #536 by @Dhruvi16

Description

Updates the reactivity of the menu.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

webpack/js/main.js Outdated Show resolved Hide resolved
@Dhruvi16 Dhruvi16 requested a review from dhruvkb October 20, 2020 04:59
@Dhruvi16
Copy link
Member Author

@dhruvkb I am not very sure regarding the step behavior in cc-search/contributing-guide/ .

@TimidRobot TimidRobot requested a review from a team as a code owner April 9, 2021 16:56
Comment on lines +2 to +8
$(window).scroll(function () {
if ($(this).scrollTop() > 500) {
$('#back-to-top').fadeIn();
} else {
$('#back-to-top').fadeOut();
}
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no #back-to-top on the site anymore.

@TimidRobot TimidRobot requested review from a team as code owners March 8, 2023 16:47
@TimidRobot TimidRobot requested review from annatuma and Shafiya-Heena and removed request for zackkrida and a team March 8, 2023 16:47
@TimidRobot
Copy link
Member

Closing due to inactivity

@TimidRobot TimidRobot closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the secondary navigations reactive.
6 participants