Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a crate / programmatic interface #32

Open
SaadBazaz opened this issue Sep 30, 2024 · 3 comments
Open

Make a crate / programmatic interface #32

SaadBazaz opened this issue Sep 30, 2024 · 3 comments

Comments

@SaadBazaz
Copy link

Hello!
Was checking out the project and think it's cool. If this does what I think it does, i.e. it can scan a certain line for secrets using regexes / checks, are you planning to make a crate for it?

Reason: We are building out secret scanning in Biome (biomejs/biome#4118) and thought it more useful to use existing community solutions instead of building out our own. So with a crate for sensleak-rs, we can at least gauge if it's useful for our use-case.

@yaokunzhang
Copy link
Contributor

Hi! Thanks for checking out the project and for your interest. I’ve actually been involved in the development of sensleak-rs, and I’m planning to take on this issue soon. We haven’t prepared for secret scanning like this in the past, but I’ll be starting work on it in the near future. Creating a crate is definitely something we’re considering, and it’s great to hear that Biome is building out secret scanning. I believe sensleak-rs could fit well with your use case. I’ll keep you updated on the crate’s progress, and please feel free to reach out if you have any specific requirements or ideas that could align with your project.

@SaadBazaz
Copy link
Author

@yaokunzhang of course! Excited to see you taking this up! Please keep me in the loop on the progress, and do let me know if you need any help. Feel free to join the Biome Discord to alert the rest of the maintainers too.

https://discord.gg/UFeXWDpnhd

@SaadBazaz
Copy link
Author

SaadBazaz commented Oct 3, 2024

I'd highly recommend that you check out our existing implementation for secret scanning in Biome. Maybe you can recommend changes / improvements by utilizing sensleaks (or without it!)

Edit: Just an idea while passing by this again, maybe you can separate sensleak-rs and sensleak-core-rs (i.e. just the regex / secret scanning util functions) so that the dependencies are largely reduced if we just directly use the core library in Biome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants