Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] lock the aspect ratio #2

Open
marcobarilari opened this issue Nov 3, 2020 · 3 comments
Open

[ENH] lock the aspect ratio #2

marcobarilari opened this issue Nov 3, 2020 · 3 comments

Comments

@marcobarilari
Copy link
Contributor

if you enlarge/reduce it, at some point it loses the ratio proportion of height and width

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Nov 3, 2020

but is that something we want to do?

I think that I set it so that it gets "stuck" on the edge of the screen.

Also it might be that the participant has FOV with a very strange aspect ration.

@marcobarilari marcobarilari changed the title [IMP] lock the aspect ratio [ENH] lock the aspect ratio Nov 3, 2020
@marcobarilari
Copy link
Contributor Author

but is that something we want to do?

If I get your question, I would say no. We don't want the aspect ratio will be modified during this trial.

I think that I set it so that it gets "stuck" on the edge of the screen.

Yes, it gets stuck to one edge (e.g. left), but if you keep moving it towards that edge on dimension is shortened more and more (e.g. width)

Also it might be that the participant has FOV with a very strange aspect ratio.

True, so might be the case that we actually want to modify the aspect ratio, the question is how? We do not have so many buttons :)

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Nov 4, 2020

Thankfully we have 2 buttons left !!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants