Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

suggested change to callback format #111

Open
npomfret opened this issue Jan 4, 2017 · 0 comments
Open

suggested change to callback format #111

npomfret opened this issue Jan 4, 2017 · 0 comments
Labels

Comments

@npomfret
Copy link
Contributor

npomfret commented Jan 4, 2017

@jamiltz I'd like to change the native code to no longer return a url with the username and password embedded in it. It just feels a bit funky and forces the javascript to do some unnecessary parsing. Instead of returning a string url, i'd like to change both implementations to return something like this:

{
  host: "localhost",
  port: 8484,
  username: "username",
  password: "password"
}

... then we can pass these parameters around more explicitly.

Or, (maybe more secure than this) instead of passing the username and password for the local db, we just pass an encoded auth token? Putting the username and password in clear text in the url doesn't feel as good as setting the encoded auth header.

@djpongh djpongh added the icebox label Sep 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants