Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is basehandler.current_user() needed? #302

Open
movero opened this issue Aug 24, 2014 · 1 comment
Open

Is basehandler.current_user() needed? #302

movero opened this issue Aug 24, 2014 · 1 comment

Comments

@movero
Copy link
Contributor

movero commented Aug 24, 2014

lib/basehandler.py has two methods for getting a user and they are user() and current_user().

I think the latter one is not needed. The latter is only called in basehandler.py get_user_tz(), which I think could just utilize the user() method instead.

Incidentally, get_user_tz() does not seem to be called anywhere, but I'm not suggesting removing it as it could be useful in the future.

@movero
Copy link
Contributor Author

movero commented Aug 24, 2014

Hmmm, not sure now. Looking through all the calls to user() it seems like it may be better to switch most of them to current_user().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant