Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/group: typo in flag help stirng #22220

Closed
hallazzang opened this issue Oct 10, 2024 · 0 comments · Fixed by #22229
Closed

x/group: typo in flag help stirng #22220

hallazzang opened this issue Oct 10, 2024 · 0 comments · Fixed by #22229

Comments

@hallazzang
Copy link
Contributor

hallazzang commented Oct 10, 2024

According to --exec flag's help string it suggests to specify 1 to try executing the proposal immediately, but this is not true.

cmd.Flags().String(FlagExec, "", "Set to 1 to try to execute proposal immediately after creation (proposers signatures are considered as Yes votes)")

When I passed --exec 1 nothing happened.

And I realized that I needed to pass try instead.

func execFromString(execStr string) group.Exec {
exec := group.Exec_EXEC_UNSPECIFIED
if execStr == ExecTry {
exec = group.Exec_EXEC_TRY
}
return exec
}

So we need to change the help string to:

`Set to "try" to try to execute proposal immediately after creation (proposers signatures are considered as Yes votes)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

2 participants