You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What I think is a bug is that we are removing the tracing context before calling app.endBlock meaning that any interactions with the store during the endBlock won't contain the block height.
This isn't something related to v0.50 as it was present already in v0.47:
If memory serves me correct, the tracing context was introduced to primarily trace ops for txs, thus delivertx. We set it in BeginBlock and reset it in EndBlock.
I think the tracing context should've been added at the end of BeginBlock.
Summary of Bug
This is possibly a bug, but I'm not entirely sure. Opening the issue to confirm/dismiss.
At the start of
FinalizeBlock
we set the tracing context containing the block height.cosmos-sdk/baseapp/abci.go
Lines 664 to 668 in 7daf40a
Near the end we remove this tracing context (I suppose to avoid any store interactions made after the block to contain the block height):
cosmos-sdk/baseapp/abci.go
Lines 753 to 760 in 7daf40a
What I think is a bug is that we are removing the tracing context before calling
app.endBlock
meaning that any interactions with the store during the endBlock won't contain the block height.This isn't something related to v0.50 as it was present already in v0.47:
cosmos-sdk/baseapp/abci.go
Lines 213 to 221 in 3b509c1
The text was updated successfully, but these errors were encountered: