-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adoption failure on Atomic Desktops using BIOS #717
Comments
Looks like we never actually implement adoption for BIOS: |
Look more about the error, find #723 (included in I think the original designation is for hybrid partition layout which supports both BIOS and UEFI booting, so there is no such error for But for none hybrid partition disk, for example, when booting BIOS, there is no ESP device and so we hit the error.
To fix this, on none hybrid partition disk:
@travier any suggestions? Thanks! |
Ideally, bootup would skip updating the EFI if the system is BIOS booted and it can not find an EFI partition. |
Yeah, when adopting I think we can gracefully handle the case where we don't find one or the other. On CoreOS derivatives we could detect that it's a CoreOS and require finding both of them, but honestly at this point that's a real corner case because you'd have to have a really old system to need to go through that path. |
When booting
|
Ouch, does this means we should not release 0.22.0 in Fedora as that will break EFI setups there? |
I think it is safe for 0.22.0 or 0.22.1, but since 0.22.2 (which includes impl adopt-and-update for BIOS), it will break EFI update for none hybrid partition layout, get the same error when running
|
- When booting with `BIOS` and no `ESP` device detected, skip `UEFI` checking - When booting with `UEFI` and no `bios_boot` partition found, skip `BIOS` checking Fixes coreos#717
- When booting with `BIOS` and no `ESP` device detected, skip `UEFI` checking - When booting with `UEFI` and no `bios_boot` partition found, skip `BIOS` checking Fixes coreos#717
- When booting with `BIOS` and no `ESP` device detected, skip `UEFI` checking - When booting with `UEFI` and no `bios_boot` partition found, skip `BIOS` checking Fixes coreos#717
- When booting with `BIOS` and no `ESP` device detected, skip `UEFI` checking - When booting with `UEFI` and no `bios_boot` partition found, skip `BIOS` checking Fixes coreos#717
Thanks for the fixes and the testing Huijing. Let's get this in a release so that we can push it to Fedora Rawhide and soon after F41 before the freeze. |
OK, will close #727 and do a new release 0.2.23, WDYT? |
Got selinux avc denied logs using the new version:
|
The selinux issue is tracked by fedora-selinux/selinux-policy#2362 |
Yeah the attempt to confine bootupd is just causing us so many problems 😢 |
Trying to adopt / update an Atomic Desktop using BIOS boot fails:
This is on a Fedora Silverblue 41 system, installed from F40, with the latest SELinux policy fixes & bootupd code:
The text was updated successfully, but these errors were encountered: