Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore API support for Android #3

Open
brodycj opened this issue May 29, 2019 · 0 comments
Open

Restore API support for Android #3

brodycj opened this issue May 29, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@brodycj
Copy link
Contributor

brodycj commented May 29, 2019

The fork by @zxyang added support for loading the p12 certificate for Android via the API call. Update from the @EbilPanda fork changed the Android implementation in fd7ed1d to use the system certificate keystore (keychain), which seems to be an almost exact copy of johannes-staehlin/cordova-client-cert-authentication.

I think it would have been better to keep both API and system certificate support for Android. This means that this fork should have been based on the @zxyang fork, with additional cherry-pick of commits to add the iOS myp12 file association and Android system certificate capabilities (instead of the ugly merge that I did between unrelated git histories). Or maybe keep the iOS myp12 file association and Android system certificate capabilities in separate plugins.

@brodycj brodycj added the enhancement New feature or request label May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant