Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wrapping connected rte instead of root one with entity provider [] #1718

Merged
merged 1 commit into from
Aug 8, 2024
Merged

feat: wrapping connected rte instead of root one with entity provider [] #1718

merged 1 commit into from
Aug 8, 2024

Conversation

aodhagan-cf
Copy link
Contributor

@aodhagan-cf aodhagan-cf commented Aug 7, 2024 •
edited
Loading

To ensure that the reference package used is the same version as the rich text editor

@aodhagan-cf aodhagan-cf requested a review from a team as a code owner August 7, 2024 23:23
@chrishelgert
Copy link
Contributor

NIT: wonder if it would more sense to use the default richtext one and deprecate the export of ConnectedRichTextEditor.
The last time we used the default one, we had an issue if multiple locales were selected in the snapshot compare, maybe that's just a quickfix too?

chrishelgert
chrishelgert approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@chrishelgert chrishelgert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if we want to go with this approach

@aodhagan-cf aodhagan-cf merged commit 8172ebc into master Aug 8, 2024
15 checks passed
@aodhagan-cf aodhagan-cf deleted the feat/move_entity_provider_to_connect_rte branch August 8, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishelgert chrishelgert chrishelgert approved these changes

Assignees
No one assigned
Labels
package:rich-text
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aodhagan-cf @chrishelgert