-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use exit-dir, get exit status from perist_dir/ctr-id/exit #23108
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dmitry-a-l The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ab50691
to
4066128
Compare
4066128
to
8f9f3e5
Compare
Ephemeral COPR build failed. @containers/packit-build please check. |
Thanks for the PR @dmitry-a-l . It currently fails to build. Could you look at the build issues please?
|
yeah, sure will fix tomorrow |
c79ee0d
to
aa5dba1
Compare
Signed-off-by: Dmitry Lihachev <[email protected]>
aa5dba1
to
150cca2
Compare
Cockpit tests failed for commit aa5dba1. @martinpitt, @jelly, @mvollmer please check. |
Ephemeral COPR build failed. @containers/packit-build please check. |
Cockpit tests failed for commit 150cca2. @martinpitt, @jelly, @mvollmer please check. |
Cockpit tests timed out on |
A friendly reminder that this PR had no activity for 30 days. |
Does this PR introduce a user-facing change?
Currently podman calls
conmon
with--exit-dir
&--persist-dir
flags, so conmon creates two exit files - one in the exit-dir and another one in the persist-dir and removes only the first file. This MR changes this behaviour - podman will not use exit-dir at all and will remove whole persist-dir after callingconmon
Closes #23107