Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use exit-dir, get exit status from perist_dir/ctr-id/exit #23108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmitry-a-l
Copy link

@dmitry-a-l dmitry-a-l commented Jun 26, 2024

Does this PR introduce a user-facing change?

None

Currently podman calls conmon with --exit-dir & --persist-dir flags, so conmon creates two exit files - one in the exit-dir and another one in the persist-dir and removes only the first file. This MR changes this behaviour - podman will not use exit-dir at all and will remove whole persist-dir after calling conmon

Closes #23107

Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dmitry-a-l
Once this PR has been reviewed and has the lgtm label, please assign n1hility for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@lsm5
Copy link
Member

lsm5 commented Jun 26, 2024

Thanks for the PR @dmitry-a-l . It currently fails to build. Could you look at the build issues please?

 github.com/containers/podman/v5/libpod
cgo-gcc-prolog: In function ‘_cgo_108dfff6e81f_Cfunc_fork_exec_ps’:
cgo-gcc-prolog:62:49: warning: unused variable ‘_cgo_a’ [-Wunused-variable]
# github.com/containers/podman/v5/libpod
libpod/oci_conmon_common.go:933:23: multiple-value r.PersistDir(ctr) (value of type (string, error)) in single-value context
libpod/oci_conmon_common.go:939:23: multiple-value r.PersistDir(ctr) (value of type (string, error)) in single-value context
libpod/oci_missing.go:232:23: invalid operation: cannot call non-function persistDir (variable of type string)
libpod/oci_missing.go:243:23: invalid operation: cannot call non-function persistDir (variable of type string)
libpod/container_internal.go:11:2: "io/fs" imported and not used
error: Bad exit status from /var/tmp/rpm-tmp.xABZCz (%build)

@dmitry-a-l
Copy link
Author

yeah, sure

will fix tomorrow

@dmitry-a-l dmitry-a-l force-pushed the remove-persist-dir branch 4 times, most recently from c79ee0d to aa5dba1 Compare June 27, 2024 04:52
Copy link

Cockpit tests failed for commit aa5dba1. @martinpitt, @jelly, @mvollmer please check.

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link

Cockpit tests failed for commit 150cca2. @martinpitt, @jelly, @mvollmer please check.

@martinpitt
Copy link
Contributor

Cockpit tests timed out on podman pod stop -t0 pod-1, that's obviously related?

Copy link

A friendly reminder that this PR had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TmpFS gets dirty with exit files
3 participants