Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application icon broken in Flatpak installs #284

Closed
Tracked by #301 ...
mairin opened this issue Jul 12, 2022 · 1 comment · Fixed by #310
Closed
Tracked by #301 ...

Application icon broken in Flatpak installs #284

mairin opened this issue Jul 12, 2022 · 1 comment · Fixed by #310
Assignees
Labels
kind/bug 🐞 Something isn't working
Milestone

Comments

@mairin
Copy link
Member

mairin commented Jul 12, 2022

Bug description

In Flatpak installs and Linux installs, the application icon for Podman Desktop is missing. When you see it in the GNOME overview, for example, or in the dash, it looks like this:

Screenshot from 2022-07-12 14-35-47

The icon packaged with it is this one and this is what should be showing up:

com github containers desktop

The Flatpak matrix channel gave me some help in trying to debug why the icon isn't showing up because it seems to be set up correctly. We discovered a likely cause of the issue.... here is the path of the icon on my installed system:

/var/lib/flatpak/app/com.github.containers.desktop/current/active/files/share/icons/hicolor/0x0/apps/com.github.containers.desktop.png

It looks like electron is taking the icon and putting it in an "0x0" directory under the icons/hicolor directory. "0x0" is not a supported type and doesn't export the artwork properly. This is apparently a known issue with electron, from at least 2020 (see electron-userland/electron-builder#5294).

There are some workarounds in the related issues on that issue... this looks like a helpful workaround here:

_electron-userland/electron-builder#5294
develar/app-builder#42

since there is no fix so far, looks like the workaround is might be to use path to icon set directory or macOS icns file
https://www.electron.build/configuration/linux_

Operating system

Fedora 36 / x86_64

Version

next (development version)

Steps to reproduce

  1. Install either the flatpak on Linux.
  2. Launch podman-desktop, noting the application has no icon

Relevant log output

No response

Additional context

No response

@mairin mairin added the kind/bug 🐞 Something isn't working label Jul 12, 2022
This was referenced Jul 18, 2022
benoitf added a commit to benoitf/desktop that referenced this issue Jul 20, 2022
Fixes containers#284

Change-Id: I9c11137f3f6406b10676de852d03cc4ed46fd0ca
Signed-off-by: Florent Benoit <[email protected]>
benoitf added a commit that referenced this issue Jul 20, 2022
Fixes #284

Change-Id: I9c11137f3f6406b10676de852d03cc4ed46fd0ca
Signed-off-by: Florent Benoit <[email protected]>
@mairin
Copy link
Member Author

mairin commented Jul 21, 2022

This works great on F36 now, thanks! :)

@benoitf benoitf self-assigned this Jul 21, 2022
@benoitf benoitf added this to the 0.0.6 milestone Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug 🐞 Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants