From ffad59a121ae2005246dcd2f5ed4bb9d67112894 Mon Sep 17 00:00:00 2001
From: Florent Benoit <fbenoit@redhat.com>
Date: Sat, 19 Oct 2024 14:23:28 +0200
Subject: [PATCH] chore: add a property for toasts

part of https://github.com/containers/podman-desktop/issues/7399

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
---
 packages/api/src/tasks-preferences.ts            |  1 +
 .../main/src/plugin/tasks/task-manager.spec.ts   | 16 ++++++++++++++++
 packages/main/src/plugin/tasks/task-manager.ts   |  5 +++++
 3 files changed, 22 insertions(+)

diff --git a/packages/api/src/tasks-preferences.ts b/packages/api/src/tasks-preferences.ts
index 94be17724775c..e00149da3c11c 100644
--- a/packages/api/src/tasks-preferences.ts
+++ b/packages/api/src/tasks-preferences.ts
@@ -19,4 +19,5 @@
 export enum ExperimentalTasksSettings {
   SectionName = 'tasks',
   StatusBar = 'StatusBar',
+  Toast = 'Toast',
 }
diff --git a/packages/main/src/plugin/tasks/task-manager.spec.ts b/packages/main/src/plugin/tasks/task-manager.spec.ts
index 75ce9e4c0f035..20b1a16945290 100644
--- a/packages/main/src/plugin/tasks/task-manager.spec.ts
+++ b/packages/main/src/plugin/tasks/task-manager.spec.ts
@@ -56,6 +56,22 @@ test('task manager init should register a configuration option', async () => {
   const taskManager = new TaskManager(apiSender, statusBarRegistry, commandRegistry, configurationRegistry);
   taskManager.init();
   expect(configurationRegistry.registerConfigurations).toHaveBeenCalledOnce();
+  expect(configurationRegistry.registerConfigurations).toHaveBeenCalledWith(
+    expect.arrayContaining([expect.objectContaining({ id: 'preferences.experimental.tasks' })]),
+  );
+  expect(configurationRegistry.registerConfigurations).toHaveBeenCalledWith(
+    expect.arrayContaining([
+      expect.objectContaining({
+        properties: expect.objectContaining({
+          'tasks.Toast': {
+            type: 'boolean',
+            description: 'Display a notification toast when task is created',
+            default: false,
+          },
+        }),
+      }),
+    ]),
+  );
 });
 
 test('create task with title', async () => {
diff --git a/packages/main/src/plugin/tasks/task-manager.ts b/packages/main/src/plugin/tasks/task-manager.ts
index 71493fe6c1660..06b407083d803 100644
--- a/packages/main/src/plugin/tasks/task-manager.ts
+++ b/packages/main/src/plugin/tasks/task-manager.ts
@@ -62,6 +62,11 @@ export class TaskManager {
             type: 'boolean',
             default: false,
           },
+          [`${ExperimentalTasksSettings.SectionName}.${ExperimentalTasksSettings.Toast}`]: {
+            description: 'Display a notification toast when task is created',
+            type: 'boolean',
+            default: false,
+          },
         },
       },
     ]);