Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make golangci-lint fails #24

Open
mythi opened this issue Apr 14, 2023 · 3 comments
Open

make golangci-lint fails #24

mythi opened this issue Apr 14, 2023 · 3 comments

Comments

@mythi
Copy link
Contributor

mythi commented Apr 14, 2023

...with a bunch of linter errors (golangci-lint has version v1.50.1)
@fmuyassarov fmuyassarov mentioned this issue Apr 17, 2023
Closed
@fmuyassarov
Copy link
Collaborator

Perhaps it would be also good to add a github action to run golangci-lint as part of presubmit?

@klihub
Copy link
Collaborator

klihub commented Apr 17, 2023

Perhaps it would be also good to add a github action to run golangci-lint as part of presubmit?

Yes, once we have fixed this. It is a known issue and the reason why we haven't enabled running golangci-lint as part of our github actions yet.

@fmuyassarov
Copy link
Collaborator

I have submitted a fix for all the issues currently reported by the linter. Maybe we can enable it once #25 gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

golangci: fix golangci-lint reported linting issues fmuyassarov/nri-plugins
3 participants
@klihub @mythi @fmuyassarov