From c7dd90dd7bdaf2bb4998f68111e4d60738e88a49 Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Wed, 2 Oct 2024 14:57:38 +0200 Subject: [PATCH] tests: add quotes to names In podman we also run the bud tests, there I noticed a issue with the podman skip logic as it was unable to fine the build-add-https-retry-ca test name as it always expects quotes[1] In general names should be human readable so add quotes and use spaces over a dash as word separator. [1] https://github.com/containers/podman/pull/24135 Signed-off-by: Paul Holzinger --- tests/add.bats | 2 +- tests/bud.bats | 2 +- tests/chroot.bats | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/add.bats b/tests/add.bats index 77513f000e0..c03ba92b755 100644 --- a/tests/add.bats +++ b/tests/add.bats @@ -307,7 +307,7 @@ stuff/mystuff" expect_output --substring "checksum flag is not supported for local sources" } -@test add-https-retry-ca { +@test "add https retry ca" { createrandom ${TEST_SCRATCH_DIR}/randomfile mkdir -p ${TEST_SCRATCH_DIR}/private starthttpd ${TEST_SCRATCH_DIR} "" ${TEST_SCRATCH_DIR}/localhost.crt ${TEST_SCRATCH_DIR}/private/localhost.key diff --git a/tests/bud.bats b/tests/bud.bats index 76f7005a61a..23c1879fdda 100644 --- a/tests/bud.bats +++ b/tests/bud.bats @@ -6905,7 +6905,7 @@ _EOF expect_output --substring "\-\-platform=$platform" } -@test build-add-https-retry-ca { +@test "build add https retry ca" { createrandom ${TEST_SCRATCH_DIR}/randomfile mkdir -p ${TEST_SCRATCH_DIR}/private starthttpd ${TEST_SCRATCH_DIR} "" ${TEST_SCRATCH_DIR}/localhost.crt ${TEST_SCRATCH_DIR}/private/localhost.key diff --git a/tests/chroot.bats b/tests/chroot.bats index 4a10ad97d03..8df3519bdab 100644 --- a/tests/chroot.bats +++ b/tests/chroot.bats @@ -2,7 +2,7 @@ load helpers -@test chroot-mount-flags { +@test "chroot mount flags" { skip_if_no_unshare if ! test -e /etc/subuid ; then skip "we can't bind mount over /etc/subuid during the test if there is no /etc/subuid file"