Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format dollar amounts on transaction cards. #10

Open
conroy-ricketts opened this issue Oct 13, 2021 · 0 comments
Open

Format dollar amounts on transaction cards. #10

conroy-ricketts opened this issue Oct 13, 2021 · 0 comments
Assignees

Comments

@conroy-ricketts
Copy link
Owner

conroy-ricketts commented Oct 13, 2021

Right now, the transaction cards do not have any commas (i.e. $100000 instead of $100,000). We should format the dollar amounts on each transaction card to include commas before every 3 digits. Also, to prevent text wrapping issues, maybe we could instead format a symbol at the end of the dollar amount for large transactions (i.e. $100k instead of $100,000 or $2.3m instead of $2,300,000). It will be up to whoever takes this task to decide whether we should use either symbols or commas.

@plasmatical plasmatical self-assigned this Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants