-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding hazelbean #27609
base: main
Are you sure you want to change the base?
Adding hazelbean #27609
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/hazelbean/meta.yaml:
For recipes/hazelbean/meta.yaml:
|
I confirm that I am willing to be a recipe maintainer. @jandrewjohnson could you confirm that you are willing to be a maintainer as well? Please comment here if so. |
I confirm that I am willing to be a recipe maintainer. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/hazelbean/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/hazelbean/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Ok, I think this is ready for review! @conda-forge/help-python |
recipes/hazelbean/LICENSE
Outdated
@@ -0,0 +1,98 @@ | |||
https://creativecommons.org/licenses/by-nc-sa/4.0/legalcode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is in the tarball. You don't need to re-add it here.
The license file is already in the tarball from PyPI, so no need to include it here as well.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( For recipes/hazelbean/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@ocefpaf you are very right, the dependencies were a combination of actual dependencies and build tools, which were taken from the upstream package's documentation, but clearly this list was a bit larger than was needed for this package, specifically. Thanks for your review! |
recipes/hazelbean/meta.yaml
Outdated
- setuptools_scm | ||
- {{ stdlib("c") }} | ||
run: | ||
- Cython |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you do some code generation at run time, it is very likely that cython is not required to run this.
- Cython |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in dfab217
Removing setuptools. Co-authored-by: Filipe <[email protected]>
recipes/hazelbean/meta.yaml
Outdated
- numpy | ||
- setuptools | ||
- setuptools_scm | ||
- {{ stdlib("c") }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- {{ stdlib("c") }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just removed this and also libgcc
in cef1607.
recipes/hazelbean/meta.yaml
Outdated
- geopandas | ||
- google-cloud-datastore | ||
- google-cloud-storage | ||
- libgcc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing at runtime libgcc is not advised. It is very unlikely that you need this.
- libgcc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just removed this and stdlib(c)
in cef1607. The builds were failing without including libgcc
before, so I'm curious if removing both lines would result in a successful build.
- seaborn | ||
- shapely | ||
- sip | ||
- six |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if you really need six? Are you still supporting Python 2 syntax with it?
- six |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I agree with you that python2 support is no longer needed, a vendored version of a library within hazelbean
does still use six
, so it is, at this time, still a dependency.
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/hazelbean/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).