Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding hazelbean #27609

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Adding hazelbean #27609

wants to merge 37 commits into from

Conversation

phargogh
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/hazelbean/meta.yaml) and found some lint.

Here's what I've got...

For recipes/hazelbean/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: jandrewjohnson. Please ask them to comment on this PR if they are.

For recipes/hazelbean/meta.yaml:

  • No valid build backend found for Python recipe for package hazelbean using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@phargogh
Copy link
Contributor Author

I confirm that I am willing to be a recipe maintainer. @jandrewjohnson could you confirm that you are willing to be a maintainer as well? Please comment here if so.

@jandrewjohnson
Copy link

I confirm that I am willing to be a recipe maintainer.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hazelbean/meta.yaml) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hazelbean/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/hazelbean/meta.yaml:

  • No valid build backend found for Python recipe for package hazelbean using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hazelbean/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 8, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/hazelbean/meta.yaml) and found some lint.

Here's what I've got...

For recipes/hazelbean/meta.yaml:

  • requirements: run: python>=3.6 must contain a space between the name and the pin, i.e. python >=3.6
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hazelbean/meta.yaml) and found it was in an excellent condition.

@phargogh
Copy link
Contributor Author

phargogh commented Oct 9, 2024

Ok, I think this is ready for review! @conda-forge/help-python

@@ -0,0 +1,98 @@
https://creativecommons.org/licenses/by-nc-sa/4.0/legalcode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is in the tarball. You don't need to re-add it here.

The license file is already in the tarball from PyPI, so no need to
include it here as well.
@phargogh phargogh requested a review from ocefpaf October 9, 2024 16:34
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hazelbean/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipes/hazelbean/meta.yaml:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hazelbean/meta.yaml) and found it was in an excellent condition.

@phargogh
Copy link
Contributor Author

phargogh commented Oct 9, 2024

@ocefpaf you are very right, the dependencies were a combination of actual dependencies and build tools, which were taken from the upstream package's documentation, but clearly this list was a bit larger than was needed for this package, specifically. Thanks for your review!

@phargogh phargogh requested a review from ocefpaf October 9, 2024 20:56
- setuptools_scm
- {{ stdlib("c") }}
run:
- Cython
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you do some code generation at run time, it is very likely that cython is not required to run this.

Suggested change
- Cython

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in dfab217

- numpy
- setuptools
- setuptools_scm
- {{ stdlib("c") }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- {{ stdlib("c") }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed this and also libgcc in cef1607.

- geopandas
- google-cloud-datastore
- google-cloud-storage
- libgcc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing at runtime libgcc is not advised. It is very unlikely that you need this.

Suggested change
- libgcc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed this and stdlib(c) in cef1607. The builds were failing without including libgcc before, so I'm curious if removing both lines would result in a successful build.

- seaborn
- shapely
- sip
- six
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if you really need six? Are you still supporting Python 2 syntax with it?

Suggested change
- six

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree with you that python2 support is no longer needed, a vendored version of a library within hazelbean does still use six, so it is, at this time, still a dependency.

@phargogh phargogh requested a review from ocefpaf October 11, 2024 20:51
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 11, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/hazelbean/meta.yaml) and found some lint.

Here's what I've got...

For recipes/hazelbean/meta.yaml:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hazelbean/meta.yaml) and found it was in an excellent condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants