Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe is no longer updating #26

Closed
1 task done
urschrei opened this issue Feb 9, 2022 · 11 comments
Closed
1 task done

Recipe is no longer updating #26

urschrei opened this issue Feb 9, 2022 · 11 comments

Comments

@urschrei
Copy link
Contributor

urschrei commented Feb 9, 2022

@moorepants Sorry to ping you, but I'm only an occasional Anaconda user – the recipe is no longer updating. I restructured the package (Python 3 only, using pyproject.toml + setup.cfg) to incorporate new best practices but I don't know whether that's the issue. Let me know if there's anything I can do from my end…

@moorepants
Copy link
Contributor

As far as I understand we have to delete pyproject.toml files in conda forge, because it's a conflict. Conda's meta.yaml is a build instruction and so is pyproject.toml. See: conda-forge/conda-forge.github.io#1174

@moorepants
Copy link
Contributor

Lots of recipes have this:

- {{ PYTHON }} -c "__import__('os').unlink('pyproject.toml')"
- {{ PYTHON }} -m pip install . -vv

@urschrei
Copy link
Contributor Author

urschrei commented Feb 9, 2022

Ah, OK!

@moorepants
Copy link
Contributor

If that doesn't work I put a rm pyproject.toml or for windows del pyproject.toml before install. I think that works too.

@moorepants
Copy link
Contributor

I can make a PR with the update if you want.

@urschrei
Copy link
Contributor Author

urschrei commented Feb 9, 2022

Oh, thanks! There are also some requirements simplifications, minimum Python >=3.6, and we now depend on pytest for testing: https://github.com/urschrei/pyzotero/blob/ed4175e0f1a62f10984b311864c13ac453fa9ebe/setup.cfg#L35-L47

@moorepants
Copy link
Contributor

See #27

@moorepants
Copy link
Contributor

There is a PR here with the possible official recommendations: conda-forge/conda-forge.github.io#1540

@urschrei
Copy link
Contributor Author

Amazing, thanks. That should be the last of the structural changes – hopefully there'll be something more robust in place on the conda side by the time "migrate everything to pyproject.toml" becomes a hard recommendation, but I'm not in a rush to repeat any of this…

@moorepants
Copy link
Contributor

I'm not sure how that will play out. The pyproject.toml is effectively build instructions, just like conda's meta.yaml and any other package manager's spec file. Maybe there will be a way to extract info from the pyproject.toml file to be incorporated into a package manager's spec file.

@moorepants
Copy link
Contributor

Maybe something like: https://github.com/dojeda/poetry2conda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants