Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abort builds with [skip ci]/etc #629

Open
djsutherland opened this issue Aug 17, 2018 · 5 comments · May be fixed by #2297
Open

abort builds with [skip ci]/etc #629

djsutherland opened this issue Aug 17, 2018 · 5 comments · May be fixed by #2297

Comments

@djsutherland
Copy link
Contributor

djsutherland commented Aug 17, 2018 •
edited
Loading

Even though CircleCI supposedly supports [skip ci], I still usually see builds go through when I add that; not sure what I'm doing wrong, if they dropped it, or if something is misconfigured on our end. But we could work around that by changing the build scripts, or maybe ff_ci_pr_build.py, to check the commit message and abort if it sees [skip ci].

Also, since CircleCI doesn't support [skip circle] and don't seem to want to (#45 (comment)), we could more-or-less implement that here. Same for [skip travis] (travis-ci/travis-ci#5032). Or we could implement [skip mac] or something to still work when we use CircleCI for Mac builds also, or similar.

Drawback: it would prevent you from manually running builds of commits that shouldn't actually have been skipped, unless we add something to do that.
@ocefpaf
Copy link
Member

ocefpaf commented Aug 17, 2018

Drawback: it would prevent you from manually running builds of commits that shouldn't actually have been skipped, unless we add something to do that.

Not a big deal IMO, the advantages do outweigh this disadvantage.

I'm not sure how hard would be to implement that but I like the idea of a [skip mac] and [skip linux].

@djsutherland
Copy link
Contributor Author

djsutherland commented Aug 17, 2018 •
edited
Loading

I think all we need to do is have the build script run a git command to check the current commit message. Shouldn't be too difficult; I might give it a shot this weekend.

@croth1
Copy link
Contributor

croth1 commented Mar 18, 2019

This will become even more interesting once we switch to azure as the provider for many platforms.

@kynan
Copy link

kynan commented Apr 10, 2021

Any update on this? Skipping CI for Azure does not seem to work.

@wshanks wshanks linked a pull request Sep 14, 2024 that will close this issue
Open
3 tasks
@jaimergp
Copy link
Member

jaimergp commented Oct 3, 2024

I added:

With those merged and released we can close this.

@jaimergp jaimergp linked a pull request Oct 3, 2024 that will close this issue
Update ci skip documentation in infrastructure.md #2297
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ci skip documentation in infrastructure.md wshanks/conda-forge.github.io
5 participants
@djsutherland @kynan @ocefpaf @jaimergp @croth1