Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-rendering bot doesn't report lack of write permissions? #708

Open
jakirkham opened this issue May 14, 2024 · 4 comments
Open

Re-rendering bot doesn't report lack of write permissions? #708

jakirkham opened this issue May 14, 2024 · 4 comments

Comments

@jakirkham
Copy link
Member

Asked the bot recent to try re-render a few times in PR ( conda-forge/nsight-compute-feedstock#22 ). However each time the bot was unable to. Though it did not report that we lacked edit permissions ( conda-forge/nsight-compute-feedstock#22 (comment) )

Did something change about how the bot raises this information? Or is there more going on here that we are missing?

@beckermr
Copy link
Member

Are you sure it is lack of permissions and not something else? The ci log doesn't actually say what happened.

@jakirkham
Copy link
Member Author

jakirkham commented May 14, 2024

Certain. I tried to make the changes manually and ran into the same issue. Then realized the contributor did not allow writes on their fork. They had on other PRs from different forks so this one caught me by surprise as well

This is what the bot says in the error message:

WARNING:git.remote:Error lines received while fetching: error: failed to push some refs to 'https://github.com/hcho3/nsight-compute-feedstock.git'

@beckermr
Copy link
Member

Right ok. We don't check for permissions on forks. We only check for orgs. Certainly one could add a change for forks on prs.

@jakirkham
Copy link
Member Author

Ahh ok. For some reason was thinking we did this already

@beckermr beckermr transferred this issue from conda-forge/webservices-dispatch-action Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants