Linter should not report "excellent condition" when issues/warnings found

[mattwthompson]

Solution to issue cannot be found in the documentation.

• I checked the documentation.

Issue

The linter, and its behavior as documented to maintainers reports "excellent condition" even when it finds things it doesn't like.

conda-forge-webservices/conda_forge_webservices/linting.py

Line 161 in 67bb9cb

I just wanted to let you know that I linted all conda-recipes in your PR ({}) and found it was in an excellent condition.

These shouldn't both be the case, especially when multiple suggested changes are communicated. Sometimes these changes are not, in fact, optional. Maintainers can read into this contraction whatever they wish, which isn't something a linter should allow.

I suggest the language be scaled back closer to "good" when something is found, or possibly "acceptable" when there are several issues.

Installed packages

N/A

Environment info

N/A

[beckermr]

Thank you for this issue!

Another way to think about the language here is that we have been informally using linter hints as a location for what are more accurately described as "future lints." We may want to make that distinction explicit as well.