Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure automerge PR to close issue (with request) #393

Open
jakirkham opened this issue Jul 9, 2020 · 1 comment
Open

Configure automerge PR to close issue (with request) #393

jakirkham opened this issue Jul 9, 2020 · 1 comment

Comments

@jakirkham
Copy link
Member

It looks like the bot PR ( conda-forge/pyobjc-core-feedstock#21 ) merely references the issue ( conda-forge/pyobjc-core-feedstock#20 ) where automerging was requested. Would be good if the PR used GitHub's "closes" keyword to trigger closing the linked issue.

@beckermr
Copy link
Member

beckermr commented Jul 9, 2020

So this already works but only if you put the bot command in the title of the issue: https://github.com/conda-forge/conda-forge-webservices/blob/master/conda_forge_webservices/commands.py#L336

This behavior is consistent with how rerenders work and is intentional IIUIC. We don't want to close issues that might be for some other purpose but happen to have a bot command in them. Thus we use the issue title and whether or not it has the bot command as a hint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants