Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push to autotick bot graph when PR is closed/merged/bot-rerun #289

Open
CJ-Wright opened this issue Jan 14, 2020 · 6 comments
Open

Push to autotick bot graph when PR is closed/merged/bot-rerun #289

CJ-Wright opened this issue Jan 14, 2020 · 6 comments

Comments

@CJ-Wright
Copy link
Member

It would be great if the webservices could write to the bot's graph when a PR is closed/merged or has a bot-rerun put against it (bonus points for reopened). This will fix the bot's lackluster updating of the graph which is causing headaches around bot-rerun and migrations.

This requires:

  1. shallow clone the graph
  2. when PR meets criteria update graph's pr_json for that PR
  3. push graph back up
  4. pull graph for any updates
  5. permissions for pushing to the graph
@beckermr
Copy link
Member

beckermr commented Feb 2, 2020

With the new dynamodb instance, this issue should be an easy thing to do. We'll need some keys, but after that, the database will take care of the associated issues around updates.

@beckermr beckermr pinned this issue Feb 2, 2020
@jakirkham
Copy link
Member

Would you be able to sketch out what this work would look like?

@beckermr
Copy link
Member

beckermr commented Feb 6, 2020

Basically, the bot would watch for closed PRs that have been merged on feedstocks. If it finds one, it would push the PR json blob up to the dynamodb instance.

@beckermr
Copy link
Member

beckermr commented Feb 6, 2020

You can use boto3 to upsert the data in the right spot.

@jakirkham
Copy link
Member

Probably worth creating a separate webhook and handler for it.

@beckermr
Copy link
Member

beckermr commented Oct 6, 2020

@lguo52 If we do ever have the PR json in a real database, then we might be able to address this issue.

@beckermr beckermr mentioned this issue Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants