Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch noarch python packages to require python 3 #93

Open
mariusvniekerk opened this issue Oct 11, 2020 · 4 comments
Open

Patch noarch python packages to require python 3 #93

mariusvniekerk opened this issue Oct 11, 2020 · 4 comments

Comments

@mariusvniekerk
Copy link
Member

mariusvniekerk commented Oct 11, 2020

Should we patch all python noarch package without a python constraint built after some date (say 2020-10-01) to require python 3?

This should avoid issues with having modern noarch packages being installable in py2 whilst not working.

@isuruf
Copy link
Member

isuruf commented Oct 11, 2020

I think we can do that if there's no python constraint there. We should first add a lint to add a lower bound on python and maybe also a mini migrator to add python >=3.6

@mariusvniekerk
Copy link
Member Author

In favor of all of that

@betteridiot
Copy link

What happens here if a package is explicitly written to work on 2.7 and greater? My code was just linted conda-forge/bamnostic-feedstock#36 and the co-maintainer made the python >= 3.6 update. I was wondering if this update now prevents the package from installing on conda environments using 2.7?

@isuruf
Copy link
Member

isuruf commented Apr 30, 2021

Yes, the new packages cannot be installed in 2.7, but the old packages can be. If you want to avoid the lint, you can add python >=2.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants