Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_python_abi more robust/generic #91

Open
mbargull opened this issue Oct 8, 2020 · 2 comments
Open

Make get_python_abi more robust/generic #91

mbargull opened this issue Oct 8, 2020 · 2 comments

Comments

@mbargull
Copy link
Member

mbargull commented Oct 8, 2020

If a python version that is not listed in

if version.startswith("2.7"):
if subdir.startswith("linux"):
return "cp27mu"
return "cp27m"
elif version.startswith("2.6"):
if subdir.startswith("linux"):
return "cp26mu"
return "cp26m"
elif version.startswith("3.4"):
return "cp34m"
elif version.startswith("3.5"):
return "cp35m"
elif version.startswith("3.6"):
return "cp36m"
elif version.startswith("3.7"):
return "cp37m"
elif version.startswith("3.8"):
return "cp38"
elif version.startswith("3.9"):
return "cp39"
return None
is encountered, we get erroneous output, see #90 (comment).
This affects new versions of python and also the existing no-one-ever-uses-python <2.7 packages we have.

@mariusvniekerk
Copy link
Member

Since all of our python binaries from 3.9+ are going to just ship with the contraints baked into the package, do we even need to add another (less strict) constraint?

@isuruf
Copy link
Member

isuruf commented Oct 8, 2020

We should skip adding these for packages built after today by looking at the timestamp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants