Skip to content
This repository has been archived by the owner on Feb 19, 2024. It is now read-only.

Package object never closes File handles #16

Open
capotej opened this issue Mar 30, 2016 · 0 comments
Open

Package object never closes File handles #16

capotej opened this issue Mar 30, 2016 · 0 comments

Comments

@capotej
Copy link
Contributor

capotej commented Mar 30, 2016

As was pointed out in this thread, the Package object should aim to be as immutable as possible. Right now, we open File objects in order to read the filename of the passed in File or string path, but these are never closed. We should close these after we are done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant