Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite comparing with ICU failed on master branch #48

Open
harendra-kumar opened this issue Jul 24, 2020 · 3 comments
Open

Test suite comparing with ICU failed on master branch #48

harendra-kumar opened this issue Jul 24, 2020 · 3 comments

Comments

@harendra-kumar
Copy link
Member

The test comparing with icu, closed by #46 has failed again on master branch CI:

Failures:

  test/Properties.hs:64:9: 

  1) Comparing random strings with ICU...

       Falsified (after 2753 tests and 6 shrinks):

         NFKD

         "\127340"

I think we can put a specific test for this codepoint to get a predictable failure. Not sure why it failed with icu-66 as well, is that ppa reliable? On my machine with icu-65 it passes.

@Bodigrim
Copy link
Collaborator

Probably ppa is unreliable :(

I checked on my machine with icu-66, unicode-transforms passes 10000000 tests.

Dunno, at this point I'd go ahead as is. Alternatively we can run to ICU tests only if icu is modern enough, guarding relevant properties by t_normalizeCompareICU "\127340" check.

@harendra-kumar
Copy link
Member Author

Which distribution are you running, how did you install icu66? libicu66 on travis/focal does not seem to be normalizing "\127340" correctly.

@Bodigrim
Copy link
Collaborator

I do not have an Ubuntu machine, unfortunately. On my mac I obtained ICU via brew install icu4c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants