Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: All-in-one unicode-data #93

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Draft: All-in-one unicode-data #93

wants to merge 11 commits into from

Conversation

wismill
Copy link
Collaborator

@wismill wismill commented Sep 27, 2022

  • Rename the package unicode-data to unicode-data-core and create the all-in-one package unicode-data.
  • Use the new version scheme.

Note: This is currently based on #92 and will need to be rebased after #92 is merged.

Fixes #82, #59.

TODO:

  • Wait for Update to Unicode 15.0.0 #92 to be merged
  • Remove deprecated features
  • Add a prominent warning (in README/package description)
  • Inform the existing users of unicode-data

@harendra-kumar
Copy link
Member

  1. Since unicode-data is now a large package we should provide a prominent warning (in README/package description) that this may be a heavier dependency, taking more time to compile and more disk space. Users may want to consider depending on individual packages esp unicode-data-core for lightweight use.
  2. We should proactively inform the existing users of unicode-data (using reverse dependencies, maybe raise issues in their repos) that they should depend on unicode-data-core instead, otherwise this may come as a surprise to them.

@harendra-kumar
Copy link
Member

Note: This is currently based on #92 and will need to be rebased after #92 is merged.

You could choose wip/Unicode_15.0.0 as the base branch for this PR.

@wismill
Copy link
Collaborator Author

wismill commented Sep 27, 2022

I agree with your proposals. I think there is no rush, so we can wait that users first update to 0.4 (#92). Then it would be a good time to remove deprecated features as well.

@wismill
Copy link
Collaborator Author

wismill commented Sep 27, 2022

We can communicate the change. As common sense, users should use upper bounds for all dependencies and consult changelogs. As this will be a big version increase, I think there should be no surprise if bounds are set.

@wismill
Copy link
Collaborator Author

wismill commented Oct 13, 2022

Rebased & add warning.

@wismill wismill marked this pull request as draft June 8, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split into unicode-data-core and unicode-data
2 participants