Replace functionality of csv with streamly #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| where | ||
|
|
||
| parseLine ls = |
There was a problem hiding this comment.
ls is confusing as it means lines, should be xs instead.
| where | ||
|
|
||
| parseLine ls = | ||
| Stream.toList $ Stream.splitOn (== ',') Fold.toList $ Stream.fromList ls |
There was a problem hiding this comment.
This won't work with quoted fields that include escaped commas. We had frame parsing in streamly for that use case, but not sure if we have implemented it yet.
| @@ -81,6 +87,28 @@ filterSanity label old new = do | |||
| ++ "\nOriginal groups: " ++ show old | |||
| ++ "\nNew groups: " ++ show new | |||
|
|
|||
| type CSV = [[String]] | |||
|
|
|||
| -- XXX This is ugly in performance but works for the time being. | |||
There was a problem hiding this comment.
Why would that be the case?
There was a problem hiding this comment.
I'm not truly streaming. I'm not using folds or parsers which I believe is more cleaner and the pipeline is more likely to fuse resulting in better performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.