Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Shift in Image Space (Translation) #103

Open
9 tasks
ninamiolane opened this issue Apr 29, 2022 · 1 comment
Open
9 tasks

Implement Shift in Image Space (Translation) #103

ninamiolane opened this issue Apr 29, 2022 · 1 comment

Comments

@ninamiolane
Copy link
Contributor

ninamiolane commented Apr 29, 2022

What?

  • Implement the shift operation of the cryo-EM image formation model in image space, which is a translation operation.
  • Add details about the structure of the config input to the docstrings of the simSPI/linear_simulator/shift_utils.py module.
  • Add corresponding unit-tests.
  • Use pre-commit (see README) to make sure that your code follows style guidelines.

Why?

Cryo-EM image formation model has different characteristics depending on whether it is formulated in image space (real space) or Fourier space (reciprocal space).

The community needs to be able to experiment with both formulations of the image formation model.

Where?

How?

  • Rename the shift_utils.py module into shift.py and make sure the unit-tests and notebooks run.
  • Allow the config input to the Shift class to have a space key, where the value will be either image or fourier.
  • Rename current forward method into a private _forward_fourier method.
  • Create a _forward_image method, with the projection operation in fourier space.
  • Create a forward method that calls either _forward_image or _forward_fourier depending on the value in the self.config attribute.

Details on the cryo-EM image formation models can be found in Donnat et al 2022.

@ninamiolane ninamiolane changed the title Implement Shift in Image Space Implement Shift in Image Space (Translation) Apr 29, 2022
@ninamiolane ninamiolane added this to the PIMS - Hackathon milestone Apr 29, 2022
@ninamiolane
Copy link
Contributor Author

@gggg is working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant