Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: add PATH_OFFSET_Z constant #33802

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ui: add PATH_OFFSET_Z constant #33802

wants to merge 1 commit into from
+3 −2

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Oct 16, 2024 •
edited
Loading

Replaced hardcoded Z-offsets with PATH_OFFSET_Z to ensure consistent Z-offset usage for both the lead and path, improving visual clarity.

@github-actions github-actions bot added the ui label Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

UI Preview

All Screenshots

@jyoung8607
Copy link
Collaborator

jyoung8607 commented Oct 16, 2024 •
edited
Loading

Separate from your work, I think the static value makes the path appear noticeably different on short vs tall cars.

@YassineYousfi could liveCalibration.height[0] serve to replace this constant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deanlee @jyoung8607