Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Implement smooth D and ID illuminants in CIE 204:2013 "Methods for Re-defining CIE D Illuminants" #1242

Open
Artoria2e5 opened this issue Jan 28, 2024 · 3 comments
Assignees
Milestone

Comments

@Artoria2e5
Copy link

Artoria2e5 commented Jan 28, 2024

Description

CIE 204:2013 "Methods for Re-defining CIE D Illuminants" (https://cie.co.at/publications/methods-re-defining-cie-d-illuminants) defines a number of "highly smoothed" versions of the D and ID illuminants. They are referenced in https://www.oscars.org/sites/oscars/files/ssi_overview_2020-09-16.pdf.

PS. colour also doesn't seem to have a thing for "D illuminant of arbitrary CCT"? There are basis functions, but I don't see anything mixing them together.

PPS. The documentation on top of https://github.com/colour-science/colour/blob/develop/colour/colorimetry/datasets/illuminants/sds.py is not getting rendered on the website, as the API doc switched to a more RST-driven approach.

(No, I don't need it for anything. I'm just being a squirrel and collecting stuff.)

@KelSolaar
Copy link
Member

Hello @Artoria2e5,

Thanks, I vaguely remember seeing those versions of the CIE illuminant D series but we never implemented them. That could be an interesting thing to add for sure. We are currently linearly interpolating them. Any thoughts @tjdcs?

We do have generation of CIE illuminant D series for arbitrary CCT, see the docstring here: https://colour.readthedocs.io/en/develop/generated/colour.sd_CIE_illuminant_D_series.html#colour.sd_CIE_illuminant_D_series

is not getting rendered on the website

I know, it sadly happened when we switched from a fully automated API documentation generation to a more manual one.

Cheers,

Thomas

@KelSolaar KelSolaar added this to the v0.4.5 milestone Jan 28, 2024
@tjdcs tjdcs self-assigned this Feb 12, 2024
@tjdcs
Copy link
Contributor

tjdcs commented Feb 12, 2024

I can take this issue at some point in the near future. It's relevant to my other work. @KelSolaar Can we please purchase the relevant standards? Or if we would prefer, I can access them via my other legal means. I just wouldn't be able to share them with the colour-maintenence team.

@KelSolaar
Copy link
Member

Yes I have planned to purchase it! Will loop you in when it is done!

@KelSolaar KelSolaar modified the milestones: v0.4.5, v0.4.6, v0.4.7 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants