Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change /api/getItem to GET instead of POST #54

Open
mynameisfiber opened this issue Sep 19, 2015 · 6 comments
Open

Change /api/getItem to GET instead of POST #54

mynameisfiber opened this issue Sep 19, 2015 · 6 comments

Comments

@mynameisfiber
Copy link
Member

API should be GET /api/getItem?id=<id> instead of POST
@mynameisfiber
Copy link
Member Author

actually, we should change all the POST's to GET

@moradology
Copy link
Contributor

+1

@veryeasily
Copy link

also should probably just be /api/item, seems weird to have the HTTP verb in the endpoint name

@wannabeCitizen
Copy link
Contributor

👍

@veryeasily
Copy link

+1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍 +1 👍

@murrayju
Copy link
Contributor

could also be GET /api/item/<id>, so you don't need a query parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mynameisfiber @murrayju @veryeasily @moradology @wannabeCitizen