Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to minify the code #33

Closed
valgussev opened this issue Feb 9, 2019 · 1 comment · Fixed by #42
Closed

Failed to minify the code #33

valgussev opened this issue Feb 9, 2019 · 1 comment · Fixed by #42
Labels
bug Something isn't working

Comments

@valgussev
Copy link

valgussev commented Feb 9, 2019 •
edited
Loading

In this commit 9d39736 retry-axios has been introduced (v1.4.2) which in compiled version contains not transpiled es6 code, which leads to the following error in create-react-app build process:

Failed to minify the code from this file: 
 	./node_modules/@cognite/sdk/node_modules/retry-axios/build/src/index.js:67 
Read more here: http://bit.ly/2tRViJ9

Explanation could be found here https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify. All applications which are using older version of cra will fail to build.
@valgussev valgussev assigned ghost Feb 9, 2019
@ghost
Copy link

ghost commented Feb 11, 2019

I have created a pull request here: JustinBeckwith/retry-axios#38
and I have reported to es-check that our es5-test (yarn esCheck) didn't find the issue: dollarshaveclub/es-check#90

@ghost ghost added the bug Something isn't working label Feb 11, 2019
This was referenced Feb 19, 2019
Closed
Merged
@ghost ghost closed this as completed in #42 Feb 19, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@valgussev