Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive notifications, then get signed out: resulting behavior is confusing #1405

Open
cellio opened this issue Sep 12, 2024 · 1 comment
Open
Labels
area: ruby Changes to server-side code complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. priority: low type: change request New feature or request

Comments

@cellio
Copy link
Member

cellio commented Sep 12, 2024

meta:291589

If you have unread notifications and then get signed out behind the scenes (this sometimes happens), the page does not refresh, so you'll still see the notification widget. If you click on it in this state, you get a blank notifications pane. Are we able to detect this and prompt you to log back in? I realize that most of the activity here is client-side and the client doesn't know you've been logged out, but maybe if the notifications come back empty, we could do an extra server call to find out if you're still logged in? Alternatively, if being logged out somehow pushed a client refresh (so you'd see the "sign in" button instead of your avatar), that would accomplish the same thing. I'm not sure what's practical here.

@cellio cellio added area: ruby Changes to server-side code type: change request New feature or request priority: low complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. labels Sep 12, 2024
@trichoplax
Copy link
Contributor

It appears that every time you open the notifications panel, a request is made to get the latest notifications. If you are signed in, this comes back as a 200 (success), whereas if you are signed out, this comes back as a 401 (unauthorised), so even without an extra server call the notifications panel has the information it needs to display a sign in link when appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ruby Changes to server-side code complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. priority: low type: change request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants