Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift & down arrow doesn't select multiple lines when a block has inline toolbar enabled #2849

Open
RichAWarren opened this issue Oct 18, 2024 · 2 comments
Labels

Comments

@RichAWarren
Copy link

RichAWarren commented Oct 18, 2024

When selecting text across multiple lines holding shift and using the down arrow you can't select more than one line as the inline toolbar opens and you start to move through the options. Holding shift and using other arrows does work as expected

Oct-18-2024 16-31-34

No setup needed you can replicate on the demo on https://editorjs.io/.

@vincenzopirozzideveloper
Copy link

vincenzopirozzideveloper commented Oct 20, 2024

Hi @RichAWarren,

Thank you for raising this issue. I happened to come across this repository and wanted to contribute to the discussion.

What you are experiencing may not necessarily be a bug but rather a result of how the inline toolbar behaves. When holding "Shift" and pressing the down arrow, the toolbar opens and indeed interrupts the selection process. However, there’s a simple workaround to continue selecting multiple lines:

After the toolbar opens, press the up arrow once. This action will close the toolbar.
Then, press the down arrow again while holding "Shift" to continue selecting the next line of text.
Once you select more text, the toolbar may reappear. You can repeat this process: press "Shift" + up arrow to close the toolbar, then continue with the down arrow to select more text.
Using this combination of arrows (up to close the toolbar, down to select more text) should allow you to select multiple lines successfully.

I hope this helps! Let me know if you have any further questions.

Best regards,
Vincenzo Pirozzi

2024-10-2020-54-43-ezgif com-video-to-gif-converter

@RichAWarren
Copy link
Author

Hey,

I feel like that is a abit of work around rather than a solution and not something that would be logical to an end user (our editorjs is customer-facing, like I suspect most are). I can't replicate the same behaviour on any other writing platforms, notion included.

I would think the best behaviour is to be able to keep highlighting behind the inline toolbar (so dont move the keyboard arrow action to the inline toolbar but leave it within the text on page), this how notion works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants