Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing emojis to sentences that do not have them #285

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add missing emojis to sentences that do not have them #285

wants to merge 2 commits into from
+15 −15

Conversation

CBID2
Copy link

@CBID2 CBID2 commented Oct 21, 2024

Description

There was some sentences that were missing emojis, so I added them

Issue

Closes #284

intelagense
intelagense requested changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@intelagense intelagense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fun PR! Although the instructions do say to add emojis to the end, I’m fine with bending the rules a bit to better accommodate a global audience.

With that in mind, if a line already has an emoticon or emoji anywhere, let's keep it as is since it adds to the charm. If a line has neither, then adding an emoji would be great.

CBID2
CBID2 commented Oct 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
CBID2
CBID2 commented Oct 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
CBID2
CBID2 commented Oct 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
CBID2
CBID2 commented Oct 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
CBID2
CBID2 commented Oct 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
CBID2
CBID2 commented Oct 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
CBID2
CBID2 commented Oct 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
CBID2
CBID2 commented Oct 23, 2024
View reviewed changes
Copy link
Author

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add these changes

@CBID2
Copy link
Author

CBID2 commented Oct 23, 2024

This is a fun PR! Although the instructions do say to add emojis to the end, I’m fine with bending the rules a bit to better accommodate a global audience.

With that in mind, if a line already has an emoticon or emoji anywhere, let's keep it as is since it adds to the charm. If a line has neither, then adding an emoji would be great.

Hi @intelagense! :) I made the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intelagense intelagense Awaiting requested review from intelagense

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: Missing emojis
2 participants
@CBID2 @intelagense