-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing emojis to sentences that do not have them #285
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fun PR! Although the instructions do say to add emojis to the end, I’m fine with bending the rules a bit to better accommodate a global audience.
With that in mind, if a line already has an emoticon or emoji anywhere, let's keep it as is since it adds to the charm. If a line has neither, then adding an emoji would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add these changes
Hi @intelagense! :) I made the changes |
Description
There was some sentences that were missing emojis, so I added them
Issue
Closes #284