Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can support Modbus RTU over TCP? #65

Open
seabig6 opened this issue Jun 22, 2024 · 3 comments
Open

Can support Modbus RTU over TCP? #65

seabig6 opened this issue Jun 22, 2024 · 3 comments

Comments

@seabig6
Copy link

seabig6 commented Jun 22, 2024

Can we add support for RTU over TCP, which means adding CRC segments at the end of the data?Can we add support for RTU over TCP, which means adding CRC segments at the end of the data?

@seabig6
Copy link
Author

seabig6 commented Jul 23, 2024

source.zip

I try to wirte, could you merge to lib?

@plpolak
Copy link
Member

plpolak commented Aug 29, 2024

Looks like your implementation is a copy with addition of the new functionality. Please change it to avoid code duplication: add a new property to enable RTU over TCP, and implement the additional logic in the existing components.

Please also do not touch the formatting of the existing code. This causes a lot of irrelevant updates in git, making it difficult to spot the actual changes.

@seabig6
Copy link
Author

seabig6 commented Aug 29, 2024

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants