Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect platform identifier in "ModBusPlatforms.inc" for Delphi XE5 #44

Open
toxicdream opened this issue Jul 9, 2020 · 0 comments
Open

Comments

@toxicdream
Copy link

toxicdream commented Jul 9, 2020

For Delphi XE5 all platform identifiers in System.Classes:

  { Platform identifiers }
  pidWin32        = $0001;
  pidWin64        = $0002;
  pidOSX32        = $0004;
  pidiOSSimulator = $0008;
  pidAndroid      = $0010;
  pidLinux32      = $0020;
  pidiOSDevice    = $0040;

  pidWinNX32      = $0100;

But in ModBusPlatforms.inc witten pidOSX:

{$IFDEF DMB_DELPHIXE3}
  [ComponentPlatformsAttribute(pidWin32 or pidWin64 or
  {$IFDEF DMB_DELPHI10_2_TOKYO}
                               pidLinux32 or pidLinux64 or
  {$ENDIF}
  {$IFDEF DMB_DELPHI10_1_BERLIN}
                               pidiOSDevice32 or pidiOSSimulator32 or
                               pidAndroid32Arm or pidAndroid64Arm or
                               pidiOSDevice64 or pidiOSSimulator64 or
  {$ELSE}
    {$IFDEF DMB_DELPHIXE4}
                               pidiOSDevice or pidiOSSimulator or
    {$ENDIF}
    {$IFDEF DMB_DELPHIXE5}
                               pidAndroid or
    {$ENDIF}
  {$ENDIF}
  {$IFDEF DMB_DELPHI10_3_RIO}
                               pidOSX32 or pidOSX64 or
  {$ELSE}
                               pidOSX or // it is no correct for Delphi XE5
  {$ENDIF}
                               0)] // Make statement complete with 0 (which is harmless)
{$ENDIF}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant