Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable usage check #122

Open
robertauer opened this issue Apr 20, 2016 · 1 comment
Open

Variable usage check #122

robertauer opened this issue Apr 20, 2016 · 1 comment
Labels
enhancement

Comments

@robertauer
Copy link
Member

Some variables in the startup.sh files are not used in them or the templates and should therefore be removed. Some variables should not be hardcoded but be set using etcd/get_config.
@robertauer robertauer self-assigned this Apr 20, 2016
@robertauer
Copy link
Member Author

robertauer commented Apr 20, 2016 •
edited
Loading

Possible occurrences:

  • cas/startup.sh line 7-10
  • postfix/startup.sh.save line 13
  • jenkins/startup.sh line 7 & 34
  • redmine/startup.sh line 15
  • scm/startup.sh line 5-13
  • nexus/startup.sh line 5&6
  • registrator/Dockerfile line 10
  • sonar/startup.sh line 4
  • universeadm/startup.sh line 8-13

robertauer added a commit that referenced this issue Apr 20, 2016
@robertauer
Changed sonar config to use get_config admin_group; #122
d9558fc
@robertauer robertauer removed their assignment Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertauer