Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: make utility classes proper utilities #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

style: make utility classes proper utilities #346

wants to merge 1 commit into from

Conversation

vil02
Copy link

@vil02 vil02 commented Oct 7, 2024

Brief Summary of Changes

All changed classes are now marked as final and their default constructor as private (i.e. it is hidden).

What does this PR address?

Are tests included?

  • Yes
  • No

Reviewer, please note:

Fixes #340.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I ran the full test suite before pushing the changes and all the tests pass.

@vil02 vil02 force-pushed the 340_hide_constructors_of_utils branch from 3c056ce to b51be82 Compare October 7, 2024 15:37
@vil02 vil02 force-pushed the 340_hide_constructors_of_utils branch from b51be82 to 19fc5a1 Compare October 7, 2024 15:42
@vil02 vil02 marked this pull request as ready for review October 7, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide constructors of utility classes
1 participant
@vil02