Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Externalize NTP and DNS as variables #469

Open
haydonryan opened this issue Aug 21, 2024 · 6 comments
Open

Please Externalize NTP and DNS as variables #469

haydonryan opened this issue Aug 21, 2024 · 6 comments

Comments

@haydonryan
Copy link

Most enterprises don't use google dns, and they'll use their own. Homelabs are in the same boat.

Removing the ops file (https://github.com/cloudfoundry/bosh-deployment/blob/master/local-dns.yml) removes the ability to replace the DNS.

https://github.com/cloudfoundry/bosh-deployment/blob/master/bosh.yml#L139
https://github.com/cloudfoundry/bosh-deployment/blob/master/bosh.yml#L45-L48
https://github.com/cloudfoundry/bosh-deployment/blob/master/bosh.yml#L164-L167

@haydonryan haydonryan changed the title Please Externalize NTP and DnS as a variable Please Externalize NTP and DNS as variables Aug 21, 2024
@haydonryan
Copy link
Author

Also the refernce on

local-dns.yml: Enables Director DNS beta functionality

https://github.com/cloudfoundry/bosh-deployment/tree/master?tab=readme-ov-file refers to an empty opsfile.

@jpalermo
Copy link
Member

The local-dns ops file never allowed override of dns servers. It was used to enable the local_dns feature of bosh. You can see the old version of it here

There is an existing ops-file to replace the dns entries here: https://github.com/cloudfoundry/bosh-deployment/blob/master/misc/dns.yml

And the one to replace ntp values is here: https://github.com/cloudfoundry/bosh-deployment/blob/master/misc/ntp.yml

Typically empty ops-file are kept around when values are incorporated into defaults so people who have pipelines or tooling using those scripts don't see those things break as we make changes.

@haydonryan
Copy link
Author

Ahh that makes sense on the local_dns and empty ops files.

I'm coming back from a hiatus to an implementation role. I assume PR for documentation updates is welcome?

@beyhan
Copy link
Member

beyhan commented Sep 20, 2024

I assume PR for documentation updates is welcome?

yes, this is very welcome :-)

@haydonryan
Copy link
Author

Awesome :)

@haydonryan
Copy link
Author

Reopening to attach to PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants