Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #342

Open
fredr opened this issue Jul 29, 2024 · 3 comments
Open

Windows support #342

fredr opened this issue Jul 29, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@fredr
Copy link
Contributor

fredr commented Jul 29, 2024

What is the problem your feature solves, or the need it fulfills?

We are building an application that uses pingora as a gateway. In production we always run on linux, but we have a use-case where we need to run it on windows so that developers can run the application locally.

Describe the solution you'd like

I'm happy to put in the work to get pingora running on windows by disabling features that are unix-only (like daemonization), and to find some solution for the use of std::os::unix throughout pingora.

Would you be open to get a feature like that merged into pingora? Do you have any concerns, or any requirement for getting it approved?

@eaufavor eaufavor added the enhancement New feature or request label Aug 2, 2024
@eaufavor
Copy link
Member

eaufavor commented Aug 2, 2024

No technical concerns. The only concern I have is the maintenance overhead of one more platform.

I will check with the team regarding the level of effort we will commit to for supporting Windows so that we can provide the accurate expectations. Meanwhile, any PRs to help making it work on non Unix platforms is welcomed.

@fredr
Copy link
Contributor Author

fredr commented Aug 14, 2024

That sounds very reasonable. In terms of expectations from my end, if Linux is tier 1 and other Unix systems are best effort and might miss some features, I would expect Windows somewhere after that, missing some more features since the difference between Windows and Unix is greater than Linux and other Unix systems. It would just be nice to have the basic support for Windows so that systems that use pingora can be made to work on Windows as well.

@eaufavor
Copy link
Member

To close the loop, the team is on board. We will probably rely heavily on community members like you to make sure that our future versions will work on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants